testing: hwy testing strategies#5136
Open
lgritz wants to merge 1 commit intoAcademySoftwareFoundation:mainfrom
Open
testing: hwy testing strategies#5136lgritz wants to merge 1 commit intoAcademySoftwareFoundation:mainfrom
lgritz wants to merge 1 commit intoAcademySoftwareFoundation:mainfrom
Conversation
1. Some tests are repeated, run once with hwy off and once with hwy on. The "on" version append ".hwy" to the test name and set the OPENIMAGEIO_ENABLE_HWY=1 environment variable to force it on while running the test. The advantage to this approach is that the test itself doesn't need to change at all, we just run it separately in each mode. In this PR, I do this with oiiotool, oiiotool-xform, and docs-examples-cpp. For now, while hwy is not enabled by default, it's doing these extra things to enable hwy. Eventually, if/when hwy is enabled by default, we'll flip the sense and use the env variable to turn it off. 2. Some tests do certain operations both ways when hwy support was enabled at build time. This is more convenient for certain unit test executables, where perhaps we want to benchmark both ways and have those show up right next to each other within the run. In this PR, I do this with the imagebufalgo_test unit test. Signed-off-by: Larry Gritz <lg@larrygritz.com>
lgritz
added
internals
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some tests are repeated, run once with hwy off and once with hwy on. The "on" versions append ".hwy" to the test name and set the OPENIMAGEIO_ENABLE_HWY=1 environment variable to force it on while running the test. The advantage to this approach is that the test itself doesn't need to change at all, we just run it separately in each mode.
In this PR, I do this with oiiotool, oiiotool-xform, and docs-examples-cpp.
For now, while hwy is not enabled by default, it's doing these extra things to enable hwy. Eventually, if/when hwy is enabled by default, we'll flip the sense and use the env variable to turn it off.
Some tests do certain operations both ways when hwy support was enabled at build time. This is more convenient for certain unit test executables, where perhaps we want to benchmark both ways and have those show up right next to each other within the run.
In this PR, I do this with the imagebufalgo_test unit test.